Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path Coherence Model to correctly handle empty documents #3406

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

PrimozGodec
Copy link
Contributor

Fixes #3368
Before #3197 empty documents were skipped, after changes coherence fails if any document without tokens is in the list.

Fixing to also work when documents without tokens are in the list.

@piskvorky piskvorky added this to the Next release milestone Nov 19, 2022
@mpenkov mpenkov added the bug Issue described a bug label Dec 6, 2022
@mpenkov mpenkov changed the title [FIX] Coherence Model - work on documents without tokens Path Coherence Model to correctly handle empty documents Dec 6, 2022
@mpenkov mpenkov merged commit 3f536fb into piskvorky:develop Dec 6, 2022
@mpenkov
Copy link
Collaborator

mpenkov commented Dec 6, 2022

Thank you @PrimozGodec !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue described a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CoherenceModel does not finish with computing
3 participants